Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete minor unreachable code caused by log.Fatal #15714

Merged
merged 5 commits into from
Oct 11, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

Description

Changes proposed in this pull request:

  • delete minor unreachable code caused by log.Fatal
  • bump Application Connector test image

Related issue(s)

See also #15061 @mvshao

@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 5, 2022

Hi @Abirdcfly. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2022
Copy link
Contributor

@franpog859 franpog859 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image version that is built in this PR is PR-15714. Please, change this and I think it's ok to merge, right @mvshao ?

@mvshao
Copy link
Contributor

mvshao commented Oct 5, 2022

Yes, @franpog859 it looks ok, now I will run the pipeline tests.

Abirdcfly and others added 3 commits October 6, 2022 00:05
…y-test/values.yaml

Co-authored-by: Franciszek Pogodziński <32485355+franpog859@users.noreply.github.com>
@mvshao
Copy link
Contributor

mvshao commented Oct 11, 2022

/test all

Copy link
Contributor

@mvshao mvshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 11, 2022
@kyma-bot
Copy link
Contributor

@Abirdcfly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-check-users-map 04f4a51 link false /test pre-main-check-users-map

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 7513661 into kyma-project:main Oct 11, 2022
@Abirdcfly Abirdcfly deleted the patch-1 branch October 11, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants