-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete minor unreachable code caused by log.Fatal #15714
Conversation
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Hi @Abirdcfly. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image version that is built in this PR is PR-15714
. Please, change this and I think it's ok to merge, right @mvshao ?
tests/components/application-connector/resources/charts/gateway-test/values.yaml
Outdated
Show resolved
Hide resolved
Yes, @franpog859 it looks ok, now I will run the pipeline tests. |
…y-test/values.yaml Co-authored-by: Franciszek Pogodziński <32485355+franpog859@users.noreply.github.com>
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Abirdcfly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Abirdcfly fp544037857@gmail.com
Description
Changes proposed in this pull request:
Related issue(s)
See also #15061 @mvshao