-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete minor unreachable code caused by log.Fatal #15061
Conversation
Hi @Abirdcfly. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in code look good to me! But you need to update the mock-app image version in tests/components/application-connector/resources/charts/gateway-test/values.yaml
file.
/test all |
@Abirdcfly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
It looks like my error rebase brought in a large number of reviewers, and although it seems I corrected the error, those review requests were not cancelled. (bot bug?) I should close this pr and re-open another one. Sorry to bother everyone. |
Signed-off-by: Abirdcfly fp544037857@gmail.com
Description
Changes proposed in this pull request:
Related issue(s)