-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix minor code unreachability error #10771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abirdcfly
requested review from
deepthi,
rafael,
harshit-gangal,
systay and
GuptaManan100
as code owners
July 21, 2022 06:01
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Abirdcfly
changed the title
wip:fix minor code unreachability error
fix minor code unreachability error
Jul 21, 2022
This commit should be able to backport to an older version, but I'm not sure if it's necessary. |
This comment was marked as resolved.
This comment was marked as resolved.
frouioui
added
Type: Testing
Component: General
Changes throughout the code base
Type: Bug
labels
Jul 21, 2022
systay
reviewed
Jul 27, 2022
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
systay
approved these changes
Aug 1, 2022
deepthi
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all feedback has been addressed.
Thank you for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abirdcfly fp544037857@gmail.com
Description
Related Issue(s)
Fixes #10772
Checklist
Deployment Notes