Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor code unreachability error #10771

Merged
merged 1 commit into from
Aug 16, 2022
Merged

fix minor code unreachability error #10771

merged 1 commit into from
Aug 16, 2022

Conversation

Abirdcfly
Copy link
Contributor

@Abirdcfly Abirdcfly commented Jul 21, 2022

Signed-off-by: Abirdcfly fp544037857@gmail.com

Description

Related Issue(s)

Fixes #10772

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 21, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@Abirdcfly Abirdcfly changed the title wip:fix minor code unreachability error fix minor code unreachability error Jul 21, 2022
@Abirdcfly
Copy link
Contributor Author

This commit should be able to backport to an older version, but I'm not sure if it's necessary.

@systay

This comment was marked as resolved.

go/vt/topo/helpers/copy.go Outdated Show resolved Hide resolved
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all feedback has been addressed.
Thank you for the contribution!

@deepthi deepthi merged commit 1939622 into vitessio:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Bug Type: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: some minor code unreachability error mainly in testing
4 participants