Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support calculate custom gpu resource #2477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Abirdcfly
Copy link
Contributor

Why are these changes needed?

  • intel use some gpu resource key like gpu.intel.com/i915
  • some gpu scheduler like HAMi support set custom gpu resource key

The above two GPU settings cannot be counted in the desiredGPU field of the raycluster status.

So I added an environment variable CUSTOM_GPU_ACCELERATOR, using commas to separate the custom gpu resource key that needs to be counted.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Copy link
Collaborator

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2425 added better support for custom accelerators, can you update the list of custom accelerators instead?

https://github.com/ray-project/kuberay/blob/master/ray-operator/controllers/ray/common/pod.go#L41-L43

This won't update the desiredGPU coloumn, but I think that's fine, we can't have coloumns for every accelerator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants