Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete minor unreachable code caused by log.Fatal #3844

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@pipecd-bot
Copy link
Collaborator

CLA

Welcome @Abirdcfly!

Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a /cla sign comment on this pull request to sign the CLA.

@Abirdcfly
Copy link
Contributor Author

/cla sign

@pipecd-bot
Copy link
Collaborator

CLA

Thank you for signing the CLA. Your signing has been successfully committed.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@nghialv nghialv changed the title delete minor unreachable code caused by log.Fatal Delete minor unreachable code caused by log.Fatal Aug 9, 2022
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@nghialv nghialv merged commit 1be8c56 into pipe-cd:master Aug 9, 2022
@github-actions github-actions bot mentioned this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants