-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete minor unreachable code caused by log.Fatal #4677
Conversation
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @tennix |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4677 +/- ##
==========================================
+ Coverage 59.75% 68.41% +8.66%
==========================================
Files 223 227 +4
Lines 25043 28023 +2980
==========================================
+ Hits 14964 19172 +4208
+ Misses 8670 7425 -1245
- Partials 1409 1426 +17
|
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bdefe51
|
Signed-off-by: Abirdcfly fp544037857@gmail.com
What problem does this PR solve?
https://pkg.go.dev/log#Fatal
So the line 33
os.Exit(1)
useless, and it also causes interference and gives the illusion that if I want to return exit code 2, then all I have to do is change it toox.Exit(2)
and that's it.What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.