Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete minor unreachable code caused by log.Fatal #664

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

Issue:
Summary: https://pkg.go.dev/log#Fatalf

Fatalf is equivalent to Printf() followed by a call to os.Exit(1).

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Copy link
Owner

@metrue metrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #664 (9e17944) into master (0d278f8) will decrease coverage by 0.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
- Coverage   24.96%   24.29%   -0.67%     
==========================================
  Files          55       55              
  Lines        1951     1951              
==========================================
- Hits          487      474      -13     
- Misses       1383     1401      +18     
+ Partials       81       76       -5     
Impacted Files Coverage Δ
container_runtimes/docker/sdk/docker.go 35.50% <0.00%> (-9.43%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@metrue metrue merged commit cc8c68e into metrue:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants