change log.Fatal to log.Error to make subsequent os.Exit executable #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
log "github.com/sirupsen/logrus"
for log package:easeprobe/cmd/easeprobe/main.go
Line 37 in 88fc4e4
And we use version 1.9 (show in go.mod)
easeprobe/go.mod
Line 17 in 88fc4e4
we use
os.Exit(-1)
after line 88log.Fatalln
and line 96log.Fatalf
From Fatalln doc:
So subsequent
os.Exit(-1)
will not executable.Same with
log.Fatalf
.So, here are 2 solutions:
option 1: just delete
os.Exit(-1)
;option 2: change
log.Fatal
tolog.Error
I think option 2 is more appropriate.