Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] change limactl start timeout as command args #766

Closed
wants to merge 1 commit into from

Conversation

Abirdcfly
Copy link

The source code has a hard-coded 10-minute timeout, which interferes with situations such as when the initialization command is time-consuming, or when the network conditions are simply not good

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@Abirdcfly Abirdcfly changed the title change limactl start timeout as command args [wip] change limactl start timeout as command args Mar 29, 2022
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout has to be set after completion of downloading the image and the containerd archive.

Otherwise downloading will easily fail.

@AkihiroSuda
Copy link
Member

Also, please use real name for signing

@Abirdcfly Abirdcfly closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants