Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix minor unreachable code caused by t.Fatal #6283

Merged
merged 1 commit into from
Aug 12, 2022
Merged

fix minor unreachable code caused by t.Fatal #6283

merged 1 commit into from
Aug 12, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

@Abirdcfly Abirdcfly requested a review from a team as a code owner August 10, 2022 07:48
aarongable
aarongable reviewed Aug 10, 2022
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Rather than deleting this line, please move it above the t.Fatal() call.

@Abirdcfly
Copy link
Contributor Author

Good catch! Rather than deleting this line, please move it above the t.Fatal() call.

Done. Thanks for review.

@Abirdcfly Abirdcfly changed the title delete minor unreachable code caused by t.Fatal fix minor unreachable code caused by t.Fatal Aug 11, 2022
@Abirdcfly
fix minor unreachable code caused by t.Fatal
f9dbe7c 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@aarongable aarongable merged commit 7cd35f4 into letsencrypt:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beautifulentropy beautifulentropy beautifulentropy approved these changes

@aarongable aarongable aarongable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abirdcfly @aarongable @beautifulentropy