Update links in extensible-admission-controllers.md

[Abirdcfly]

update link

[k8s-ci-robot]

Welcome @Abirdcfly!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[Abirdcfly]

/assign @kbhawkey

[netlify]

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 257794c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5ffeaff90e3e7200088a2e33

😎 Browse the preview: https://deploy-preview-26060--kubernetes-io-master-staging.netlify.app

[kbhawkey]

Hello @Abirdcfly . Thanks for opening this pull request.
Page preview:
https://deploy-preview-26060--kubernetes-io-master-staging.netlify.app/docs/reference/access-authn-authz/extensible-admission-controllers/#write-an-admission-webhook-server

[kbhawkey]

/retitle Update links in extensible-admission-controllers.md

[kbhawkey]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 717bab5bab14a39d5829e756d277ad6375879cd3

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aut0R3V
To complete the pull request process, please assign kbhawkey after the PR has been reviewed.
You can assign the PR to them by writing /assign @kbhawkey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tengqm]

Pointing to old versions of source code is not ideal. However, pointing to the "master" branch is not a good idea either because the "master" is a moving target.
Please think twice... do we really need this link to the source code? If we do, can we use a more recent tag (rather than branch) as the link target?

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[Abirdcfly]

Pointing to old versions of source code is not ideal. However, pointing to the "master" branch is not a good idea either because the "master" is a moving target.
Please think twice... do we really need this link to the source code? If we do, can we use a more recent tag (rather than branch) as the link target?

It is common to pointing to source code. And If we want to explain clearly, it is necessary to show the source code. I have change master branch to param "githubbranch" like other pages do. 😊

[Abirdcfly]

/assign @kbhawkey

[sftim]

I like the idea of this PR. I'm worried though that these changes make things more fragile - see inline feedback.

[sftim]

If hyperlinking to a specific line, it's better to pin to a named branch (the latest release is a good choice). Otherwise if that file changes the line might end up reading something else.

[Abirdcfly]

I have check these specific line in version 1.17 to 1.20 it points to same items. 😊 If we change source code, I think it is a good idea to change website too.

[kbhawkey]

Hi @Abirdcfly .
It would be helpful to get this link updated.
Since the parameter githubbranch resolves to master, would you change this section of the link
to the current version, 1.20.0, or possibly the variable, fullversion?
This link may change in the future?

[Abirdcfly]

ping @kbhawkey

[kbhawkey]

Pointing to old versions of source code is not ideal. However, pointing to the "master" branch is not a good idea either because the "master" is a moving target.
Please think twice... do we really need this link to the source code? If we do, can we use a more recent tag (rather than branch) as the link target?

Hi @Abirdcfly . What do you think about updating the version in the links to the latest version, v1.20.0? Will that work?

[Abirdcfly]

Pointing to old versions of source code is not ideal. However, pointing to the "master" branch is not a good idea either because the "master" is a moving target.
Please think twice... do we really need this link to the source code? If we do, can we use a more recent tag (rather than branch) as the link target?

Hi @Abirdcfly . What do you think about updating the version in the links to the latest version, v1.20.0? Will that work?

It work. There are two choices:
1>. We point to v1.20.0 and when k8s v1.21.0 release, we update link to v1.21.0 ?
2>. We point to master ( param "githubbranch" like other pages ) and when source code changes, we update this link.
Based on the historical update frequency of these source code,, I think 2> is more appropriate.

[tengqm]

Pointing to master/main is never a good choice to me. Please consider pointing to a tag for latest release.

[tengqm]

/close

[k8s-ci-robot]

@tengqm: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.