manager should not panic and should ignore wrong Clusterscoped type setting in HNCConfiguration

[Abirdcfly]

No description provided.

[k8s-ci-robot]

Hi @Abirdcfly. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adrianludwin]

Great change! Do you mind making one API improvement? Please squash all the commits into one before resubmitting. Thanks!

[adrianludwin]

Do you mind using a custom Go error? That's the standard way to build this kind of logic (e.g see guide here).

Example:

type GVKError struct {
  Reason string
  Msg string
}
func (e *GVKError) Error() string {
  return e.Msg
}
...
// in GVKFor, if not namespaced:
return schema.GroupVersionKind{}, &GVKError{reason: api.ReasonResourceNotNamespaced, msg: fmt.Sprintf("Resource %q is not namespaced", gr))
...
// in caller:
reason := "internal error"
if ge, ok := err.(*GVKError); ok {
  reason = ge.Reason
}
... display the error ...

This means that the code calling GVKFor doesn't need to know about the format of the error string, and if that error string changes, the caller won't break.

[adrianludwin]

/lgtm
/approve
/hold
/assign @rjbez17
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abirdcfly, adrianludwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adrianludwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adrianludwin]

/hold cancel
@rjbez17 lmk if you have concerns about this