Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knative-with-operators.md #4091

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

Abirdcfly
Copy link
Contributor

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

@google-cla
Copy link

google-cla bot commented Aug 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 629c91e

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/6107c1c860c9ad0009db017e

😎 Browse the preview: https://deploy-preview-4091--knative.netlify.app

@google-cla google-cla bot added the cla: no Indicates the PR's author has not signed the CLA. label Aug 2, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2021
@knative-prow-robot
Copy link
Contributor

Welcome @Abirdcfly! It looks like this is your first PR to knative/docs 🎉

@knative-prow-robot
Copy link
Contributor

Hi @Abirdcfly. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2021
@Abirdcfly
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Aug 2, 2021
@Abirdcfly
Copy link
Contributor Author

/assign @bsnchan

@snneji
Copy link
Contributor

snneji commented Aug 9, 2021

Thanks for fixing this @Abirdcfly

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2021
@snneji snneji added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Aug 9, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Abirdcfly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 17cdee4 into knative:mkdocs Aug 9, 2021
@Abirdcfly Abirdcfly deleted the patch-1 branch August 9, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants