fix kn trigger list command to show correct v1/service sink output

[Abirdcfly]

Description

If the sink of the trigger is a normal service, the kn trigger list command will show it as ksvc, which is incorrect

Changes

Reference

Fixes #

[knative-prow-robot]

@Abirdcfly: 0 warnings.

In response to this:

Description

If the sink of the trigger is a normal service, the kn trigger list command will show it as ksvc, which is incorrect

Changes

Reference

Fixes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Welcome @Abirdcfly! It looks like this is your first PR to knative/client 🎉

[knative-prow-robot]

Hi @Abirdcfly. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Abirdcfly]

/assign @RichieEscarez

[itsmurugappan]

/ok-to-test

[Abirdcfly]

Only kind and name are not enough here. An error will appear: "Unable to get the Subscriber's URI"

[Abirdcfly]

Only kind and name are not enough here. An error will appear: "Unable to get the Subscriber's URI"

[itsmurugappan]

looks like Group is not stabilized, more details here -> knative/eventing#5086. But if you include the version in the check, won't it need to be changed when a new knative serving version comes?

[codecov]

Codecov Report

Merging #1428 (126e869) into main (2e71451) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 126e869 differs from pull request most recent head 19f270a. Consider uploading reports for the commit 19f270a to get more accurate results

@@           Coverage Diff           @@
##             main    #1428   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         162      162           
  Lines        8368     8368           
=======================================
  Hits         6586     6586           
  Misses       1098     1098           
  Partials      684      684           

Impacted Files	Coverage Δ
pkg/kn/commands/flags/sink.go	87.50% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e71451...19f270a. Read the comment docs.

[itsmurugappan]

everything looks good, one small suggestion.

[itsmurugappan]

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abirdcfly, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment