Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(all): delete minor unreachable code caused by t.Fatal #6494

Merged
merged 6 commits into from
Aug 11, 2022
Merged

chore(all): delete minor unreachable code caused by t.Fatal #6494

merged 6 commits into from
Aug 11, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

@Abirdcfly
chore(all): delete minor unreachable code caused by t.Fatal
d512fea 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@Abirdcfly Abirdcfly requested review from a team, enocom and telpirion as code owners August 10, 2022 06:39
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 10, 2022
codyoss
codyoss previously approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Aug 10, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 10, 2022
@gcf-merge-on-green gcf-merge-on-green bot dismissed codyoss’s stale review August 10, 2022 13:48

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Aug 10, 2022
telpirion
telpirion previously approved these changes Aug 10, 2022
View reviewed changes
hongalex
hongalex previously approved these changes Aug 10, 2022
View reviewed changes
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Aug 10, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 10, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Aug 11, 2022
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Aug 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot dismissed stale reviews from hongalex and telpirion August 11, 2022 13:26

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
codyoss
codyoss previously approved these changes Aug 11, 2022
View reviewed changes
@codyoss codyoss added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit and removed automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Aug 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot dismissed codyoss’s stale review August 11, 2022 16:04

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@codyoss codyoss merged commit 8460947 into googleapis:main Aug 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex left review comments

@telpirion telpirion telpirion left review comments

@codyoss codyoss codyoss left review comments

@enocom enocom Awaiting requested review from enocom

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Abirdcfly @codyoss @telpirion @hongalex @kokoro-team