Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/modload: use atomic.Pointer for Requirements.graph #54888

Closed
wants to merge 1 commit into from
Closed

cmd/go/internal/modload: use atomic.Pointer for Requirements.graph #54888

wants to merge 1 commit into from

Conversation

Abirdcfly
Copy link
Contributor

@Abirdcfly Abirdcfly commented Sep 6, 2022 •
edited
Loading

No description provided.

@gopherbot
Copy link
Contributor

This PR (HEAD: 1134c69) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/428716 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 1: Run-TryBot+1 Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: ed993db) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/428716 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@Abirdcfly Abirdcfly changed the title cmd/go/internal/modload: change Requirements.graph type to atomic.Poi… cmd/go/internal/modload: use atomic.Pointer for Requiremest.graph Sep 7, 2022
@gopherbot
Copy link
Contributor

Message from Abirdcfly Abirdcfly:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Abirdcfly Abirdcfly:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@Abirdcfly Abirdcfly changed the title cmd/go/internal/modload: use atomic.Pointer for Requiremest.graph cmd/go/internal/modload: use atomic.Pointer for Requirements.graph Sep 7, 2022
@gopherbot
Copy link
Contributor

Message from Zeke Lu:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Abirdcfly Abirdcfly:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 4: Run-TryBot+1 Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/428716.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 9, 2022
@Abirdcfly @gopherbot
cmd/go/internal/modload: use atomic.Pointer for Requirements.graph
1b19698 
Change-Id: Ie543e1b1df667cfaf3aafa4be727881461ee8b7d
GitHub-Last-Rev: ed993db
GitHub-Pull-Request: #54888
Reviewed-on: https://go-review.googlesource.com/c/go/+/428716
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/428716 has been merged.

@gopherbot gopherbot closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abirdcfly @gopherbot