[Filebeat] fix minor unreachable code

[Abirdcfly]

Signed-off-by: Abirdcfly fp544037857@gmail.com

• Cleanup

What does this PR do?

Why is it important?

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

• [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

[cla-checker-service]

💚 CLA has been signed

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-08-11T11:28:49.014+0000

• Duration: 75 min 4 sec

Test stats 🧪

Test	Results
Failed	0
Passed	6794
Skipped	737
Total	7531

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[efd6]

syslog change LGTM

[ShourieG]

@Abirdcfly Please add an error check to the os.MkdirAll call. Otherwise LGTM

[Abirdcfly]

@Abirdcfly Please add an error check to the os.MkdirAll call. Otherwise LGTM

Done for make golangci-lint happy.

[rdner]

This looks suspicious and it changes how the test ran. Before it was running only once and now for 120 iterations. I think it's safer to remove the loop in order to preserve the existing logic.

[Abirdcfly]

This looks suspicious and it changes how the test run. Before it was running only once and now for 120 iterations.

Yes. IMO, that was the intent of this test, only the return statement was added by mistake

I think it's safer to remove the loop in order to preserve the existing logic.

I'm keeping an open mind on this.
I'll wait a few hours, and if no other revier has a problem with it, I'll delete the loop.
@efd6 @ShourieG @cmacknz

[efd6]

Running the loop only once is not correct IMO. The point of the test is to check that a variety of syslog priorities are properly parsed into the destination value. Testing only a single value (1) is not interesting. I'm not entirely sure why it starts at 1 and stops at 120 since it would not cost significantly more to test the exhaustive range of valid priority values.

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @Abirdcfly? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)
  To fixup this pull request, you need to add the backport labels for the needed
  branches, such as:
• backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

[elasticmachine]

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[epixa]

@cmacknz Are you able to take a look at this?

[cmacknz]

Didn't realize I was holding this up. Approved, and merged. Thanks!