Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo shoulld -> should #236

Merged
merged 1 commit into from
Sep 1, 2022
Merged

typo shoulld -> should #236

merged 1 commit into from
Sep 1, 2022

Conversation

Abirdcfly
Copy link
Contributor

@samuelkarp
Copy link
Member

Would you mind updating your Signed-off-by line to use your real name? We require that as part of our contribution policy.

Just stumbled upon https://github.com/containerd/cgroups/pull/77/files#r259087886 thanks @mikebrow

Signed-off-by: Abirdcfly Fu <fp544037857@gmail.com>
@Abirdcfly
Copy link
Contributor Author

use your real name

Done. Thanks for you advice.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 04ebfd6 into containerd:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants