Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: delete minor unreachable code caused by t.Fatal #1869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Abirdcfly
Copy link

Signed-off-by: Abirdcfly fp544037857@gmail.com

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@Abirdcfly
Copy link
Author

https://github.com/cockroachdb/pebble/runs/7787638007
show TestCompactFlushQueuedMemTableAndFlushMetrics is failed in windows...

@jbowens jbowens changed the title delete minor unreachable code caused by t.Fatal db: delete minor unreachable code caused by t.Fatal Aug 11, 2022
@jbowens
Copy link
Collaborator

jbowens commented Aug 11, 2022

Yeah, it's a known flake: #1673

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants