Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete minor unreachable code caused by t.Fatal #1875

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2838423040

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 55.135%

Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
connmgr/connmanager.go 2 85.36%
Totals Coverage Status
Change from base Build 2836573928: 0.006%
Covered Lines: 26520
Relevant Lines: 48100

💛 - Coveralls

@kcalvinalvin
Copy link
Collaborator

ACK 14a1640

Looks like a simple cleanup.

@Roasbeef Roasbeef merged commit ee68dc6 into btcsuite:master Oct 8, 2024
@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 2838423040

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 55.135%

Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
connmgr/connmanager.go 2 85.36%
Totals Coverage Status
Change from base Build 2836573928: 0.006%
Covered Lines: 26520
Relevant Lines: 48100

💛 - Coveralls

@yyforyongyu
Copy link
Contributor

hmm wondering what triggered the bot...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants