Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trap ERR and format shell #12

Merged
merged 1 commit into from
Feb 10, 2023
Merged

feat: trap ERR and format shell #12

merged 1 commit into from
Feb 10, 2023

Conversation

Abirdcfly
Copy link
Member

@Abirdcfly Abirdcfly commented Feb 9, 2023 •
edited
Loading

Signed-off-by: Abirdcfly fp544037857@gmail.com

Fix #11

@Abirdcfly
feat: trap ERR and format shell
9e060e0 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
bjwswang
bjwswang approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@bjwswang bjwswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

good points to use trap print debug inf each time error occurs

@bjwswang
Copy link
Member

bjwswang commented Feb 10, 2023 •
edited
Loading

@0xff-dev make sure this pr has no bad effect on e2e.sh

@bjwswang bjwswang merged commit d404318 into bestchains:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjwswang bjwswang bjwswang approved these changes

@0xff-dev 0xff-dev 0xff-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github action should exit 1 when failed
3 participants
@Abirdcfly @bjwswang @0xff-dev