fix: use oidc args in kubectl command #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abirdcfly
force-pushed
the
fixtoken
branch
12 times, most recently
from
3cc9d77
to
02d6953
Compare
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
github-actions
bot
requested review from
0xff-dev,
bjwswang,
Lanture1064 and
nkwangleiGIT
0xff-dev
approved these changes
Apr 13, 2023
bjwswang
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #231
This pr uses some shell tricks to ensure that when the
--tokenparameter is used, the request is automatically sent tooidc-serverto confirm user permissionsAdditionally, this pr valid that network permissions are restricted to only those organizations that belong to the network.