Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete minor unreachable code caused by log.Fatal #1831

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
  • What is the current behavior?
  • What is the new behavior?
  • Other information:

See how to contribute

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1831 (a15e579) into master (3a25147) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1831      +/-   ##
==========================================
- Coverage   36.28%   36.26%   -0.02%     
==========================================
  Files         232      232              
  Lines       19496    19496              
==========================================
- Hits         7074     7071       -3     
- Misses      11592    11594       +2     
- Partials      830      831       +1     
Flag Coverage Δ
unit 36.26% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/cores/packagemanager/package_manager.go 62.18% <0.00%> (-0.85%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arduino arduino deleted a comment from CLAassistant Aug 10, 2022
@per1234 per1234 added the topic: documentation Related to documentation for the project label Aug 10, 2022
@cmaglie cmaglie merged commit 312cfdb into arduino:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants