-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix minor unreachable code caused by log.Fatal #22618
Conversation
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
R: @lostluck |
R: @jrmccluskey |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #22618 +/- ##
==========================================
- Coverage 74.20% 74.20% -0.01%
==========================================
Files 708 710 +2
Lines 93462 93547 +85
==========================================
+ Hits 69355 69414 +59
- Misses 22832 22856 +24
- Partials 1275 1277 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up! Just had a couple small comments, then I'd like to merge
Co-authored-by: Danny McCormick <dannymccormick@google.com>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the contribution!
* fix minor unreachable code caused by log.Fatal Signed-off-by: Abirdcfly <fp544037857@gmail.com> * Apply suggestions from code review Co-authored-by: Danny McCormick <dannymccormick@google.com> * Update sdks/python/container/boot.go Co-authored-by: Danny McCormick <dannymccormick@google.com> Signed-off-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Danny McCormick <dannymccormick@google.com>
https://pkg.go.dev/log#Fatalf
see https://go.dev/play/p/iw2MCkHArJZ for example:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.
R: @lostluck
R: @jrmccluskey
(just found that you have recently reviewed the go code)