Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

delete minor unreachable code caused by log.Fatal #4930

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

Reason for Change:

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@welcome
Copy link

welcome bot commented Aug 9, 2022

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackfrancis
Copy link
Member

@Abirdcfly, thanks for this! Unfortunately we'll have to rebase this on top of current master branch before we can merge.

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@Abirdcfly
Copy link
Contributor Author

@Abirdcfly, thanks for this! Unfortunately we'll have to rebase this on top of current master branch before we can merge.

Done.

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @Abirdcfly!

@jackfrancis jackfrancis merged commit c24fc03 into Azure:master Aug 18, 2022
@welcome
Copy link

welcome bot commented Aug 18, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@Abirdcfly Abirdcfly deleted the patch-1 branch August 19, 2022 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants