Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify code and add ipv6 support #7

Merged
merged 1 commit into from
Jun 22, 2024
Merged

feat: simplify code and add ipv6 support #7

merged 1 commit into from
Jun 22, 2024

Conversation

antmat
Copy link
Contributor

@antmat antmat commented Jun 4, 2024

We need an ipv6 support for dragonboat and it looks like only blocker is custom listener in goutils/netutils
I tried to figure out what this change could break and it looks pretty safe.
I also tested it in our environment and it works for us.

Thanks!

@lebovski
Copy link

@lni Merge please

@lni lni merged commit 4ae0238 into lni:master Jun 22, 2024
@lni
Copy link
Owner

lni commented Jun 22, 2024

Thanks for the PR. I don't currently have IPv6 environment to test it.

Please feel free to raise any dragonboat bugs, will be happy to fix anything that affects correctness or noticeable performance.

@antmat
Copy link
Contributor Author

antmat commented Jun 22, 2024

Thanks!
What do you think about updating go.mod in 3.3 branch and making 3.3.9 release?
It would really help us as we could use vanilla release instead of patched one

@grobza
Copy link

grobza commented Jun 24, 2024

Thanks for the PR. I don't currently have IPv6 environment to test it.

@lni me and @lebovski have an IPv6 environment and can test this. PR is here lni/dragonboat#361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants