Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dragonboat work with Pebble v1.0.0 #339

Closed
wants to merge 1 commit into from

Conversation

tylerwilliams
Copy link
Contributor

(Based off of lni/vfs#3)

@lni
Copy link
Owner

lni commented Dec 19, 2023

Could you please have a look at the above failed tests? The go version might need to be bumped to go 1.21, there seem to be other issues as well.

Thanks.

@tylerwilliams
Copy link
Contributor Author

tylerwilliams commented Dec 19, 2023

Could you please have a look at the above failed tests? The go version might need to be bumped to go 1.21, there seem to be other issues as well.

Thanks.

I'm having a difficult time making these tests pass without the vfs library change being committed. Could you take a look at that one first?

@tylerwilliams
Copy link
Contributor Author

tylerwilliams commented Dec 20, 2023

Could you please have a look at the above failed tests? The go version might need to be bumped to go 1.21, there seem to be other issues as well.
Thanks.

I'm having a difficult time making these tests pass without the vfs library change being committed. Could you take a look at that one first?

Ah, please ignore my last comment. I see this is down to a mac v linux issue. Will take a look tomorrow if I get time.

@mostcute
Copy link

it's just rand pkg changed since go1.20.0

@lni
Copy link
Owner

lni commented Dec 21, 2023

Thanks @mostcute.

I guess we can just bump the required Go version to v1.20.

@lni
Copy link
Owner

lni commented Dec 22, 2023

I've bumped dragonboat's required go version to v1.20.

@tylerwilliams would you like to merge master into your branch and give it a go? Thanks.

@tylerwilliams
Copy link
Contributor Author

closing in favor of #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants