-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dragonboat work with Pebble v1.0.0 #339
Conversation
Could you please have a look at the above failed tests? The go version might need to be bumped to go 1.21, there seem to be other issues as well. Thanks. |
bd1a952
to
ed7baca
Compare
I'm having a difficult time making these tests pass without the vfs library change being committed. Could you take a look at that one first? |
ed7baca
to
2fb1f15
Compare
2fb1f15
to
b818bde
Compare
Ah, please ignore my last comment. I see this is down to a mac v linux issue. Will take a look tomorrow if I get time. |
it's just rand pkg changed since go1.20.0 |
Thanks @mostcute. I guess we can just bump the required Go version to v1.20. |
I've bumped dragonboat's required go version to v1.20. @tylerwilliams would you like to merge master into your branch and give it a go? Thanks. |
closing in favor of #341 |
(Based off of lni/vfs#3)