Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multi bls consensus. #4809

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix for multi bls consensus. #4809

wants to merge 2 commits into from

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Dec 4, 2024

Fix for multi bls consensus.

Removed redundant call to ReadySignal, which interrupts block creating.
https://github.com/harmony-one/harmony/pull/4809/files#diff-255a5cdd5516e7293e60a47a92503360676ddffb7e48e505598a589753b568c2L851

@Frozen Frozen added the WIP Work in progress don't merge yet! label Dec 4, 2024
@Frozen Frozen self-assigned this Dec 4, 2024
@sophoah
Copy link
Contributor

sophoah commented Dec 5, 2024

current code the proposal, when it's time for the node (ie currently BINGO) to become leader, the consensus is timing out. below are the relevant logs :
BINGO on block 513:

{"level":"info","port":"9000","ip":"127.0.0.1","blockNum":513,"epochNum":8,"ViewId":523,"blockHash":"0xcd8453a38d57446bfad5d54cbce2ea56681011fb9fb0d2222a6c9b8d0d4b82f1","numTxns":0,"numStakingTxns":0,"numSignatures":6,"mode":"Normal","caller":"/home/soph/harmony/harmony2/consensus/post_processing.go:41","time":"2024-12-05T10:39:08.551773406+07:00","message":"BINGO !!! Reached Consensus"}

Detects that he is the leader for block 514 (which should be proposed):

    
{"level":"info","port":"9000","ip":"127.0.0.1","CurrentHeight":513,"ConsensusBlockNumber":514,"Epoch":8,"AssignedLeader":"02c8ff0b88f313717bc3a627d2f8bb172ba3ad3bb9ba3ecb8eed4b7c878653d3d4faf769876c528b73f343967f74a917","caller":"/home/soph/harmony/harmony2/consensus/consensus_v2.go:836","time":"2024-12-05T10:39:08.551859462+07:00","message":"Consensus Setup: I am the new leader for the next block"}

then consensus timeout

    
{"level":"warn","port":"9000","ip":"127.0.0.1","shardID":0,"myBlock":514,"myViewID":524,"phase":"Announce","mode":"Normal","caller":"/home/soph/harmony/harmony2/consensus/consensus_v2.go:430","time":"2024-12-05T10:39:35.607462231+07:00","message":"[ConsensusMainLoop] Ops Consensus Timeout!!!"}

and at the end of view change that node is elected as leader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress don't merge yet!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants