-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use testify instead of t.Fatal or t.Error in server package (part 1) #18971
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #18971 +/- ##
==========================================
- Coverage 68.78% 68.72% -0.06%
==========================================
Files 420 420
Lines 35629 35623 -6
==========================================
- Hits 24506 24482 -24
- Misses 9700 9709 +9
- Partials 1423 1432 +9 Continue to review full report in Codecov by Sentry.
|
ea9e299
to
56d9dc3
Compare
/ok-to-test |
d48d6ac
to
bd41130
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
bd41130
to
c638757
Compare
/test pull-etcd-verify |
@mmorel-35: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This uses testify instead of testing for t.Fatal or t.Error calls in server package
Related to #18972