-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use testify instead of t.Fatal or t.Error in contrib package #18968
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 25 files with indirect coverage changes @@ Coverage Diff @@
## main #18968 +/- ##
==========================================
- Coverage 68.77% 68.77% -0.01%
==========================================
Files 420 420
Lines 35598 35598
==========================================
- Hits 24483 24482 -1
- Misses 9685 9689 +4
+ Partials 1430 1427 -3 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
b0e7903
to
7f9efcf
Compare
/ok-to-test |
/retest |
Description
This uses testify instead of testing for t.Fatal or t.Error calls in contrib package
Related to #18972