-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use testify instead of t.Fatal or t.Error in client package (part 1) #18967
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
57ca7d7
to
92e97ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18967 +/- ##
==========================================
- Coverage 68.78% 68.76% -0.02%
==========================================
Files 420 420
Lines 35629 35629
==========================================
- Hits 24506 24499 -7
- Misses 9700 9706 +6
- Partials 1423 1424 +1 Continue to review full report in Codecov by Sentry.
|
92e97ed
to
629a809
Compare
/ok-to-test |
19024a8
to
287df21
Compare
…t 1) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
287df21
to
1d5a9bd
Compare
/retest |
Question, @mmorel-35. How are you planning on splitting these pull requests? I want to understand it so that I can deliver a proper review :) |
Description
This uses testify instead of testing for t.Fatal or t.Error calls in client package
Related to #18972