-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use testify instead of t.Fatal in tests/common package (part 2) #18860
base: main
Are you sure you want to change the base?
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @ahrtr |
82c6211
to
9274dc6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #18860 +/- ##
=======================================
Coverage 68.77% 68.78%
=======================================
Files 420 420
Lines 35623 35623
=======================================
+ Hits 24500 24502 +2
+ Misses 9694 9693 -1
+ Partials 1429 1428 -1 Continue to review full report in Codecov by Sentry.
|
7e7b6bd
to
59a8434
Compare
/ok-to-test |
/test pull-etcd-integration-1-cpu-amd64 |
I hold on this to apply gofumpt first |
59a8434
to
711d9ad
Compare
2f0cc2c
to
cf4c0e4
Compare
cf4c0e4
to
d7da66f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
d7da66f
to
da59651
Compare
Description
This uses testify instead of testing for t.Fatal calls
Related to #18972