fix: use testify instead of t.Fatal in tests/common package (part 2)

[mmorel-35]

Description

This uses testify instead of testing for t.Fatal calls

Related to #18972

[k8s-ci-robot]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mmorel-35]

/assign @ahrtr

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (c1171da) to head (da59651).

Additional details and impacted files

see 24 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18860   +/-   ##
=======================================
  Coverage   68.77%   68.78%           
=======================================
  Files         420      420           
  Lines       35623    35623           
=======================================
+ Hits        24500    24502    +2     
+ Misses       9694     9693    -1     
+ Partials     1429     1428    -1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1171da...da59651. Read the comment docs.

[jmhbnz]

/ok-to-test

[mmorel-35]

/test pull-etcd-integration-1-cpu-amd64

[mmorel-35]

I hold on this to apply gofumpt first

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment