-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable int-conversion rule of perfsprint #18859
base: main
Are you sure you want to change the base?
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
adae3ec
to
1e09dbe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 25 files with indirect coverage changes @@ Coverage Diff @@
## main #18859 +/- ##
==========================================
+ Coverage 68.77% 68.78% +0.01%
==========================================
Files 420 420
Lines 35598 35598
==========================================
+ Hits 24483 24487 +4
+ Misses 9685 9681 -4
Partials 1430 1430 Continue to review full report in Codecov by Sentry.
|
/assign @ahrtr |
/ok-to-test |
1e09dbe
to
5465913
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5465913
to
deafbd9
Compare
/retest |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
deafbd9
to
bebf4ce
Compare
/retest |
This fixes int-conversion rule from perfsprint
This helps avoid unnecessary memory allocations.
It doesn't include server and tests folder as they have a lot of impacted files