-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use require instead of t.Fatal(err) in tests/integration package #18820
base: main
Are you sure you want to change the base?
fix: use require instead of t.Fatal(err) in tests/integration package #18820
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @spzala |
08a5213
to
502fdc1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 37 files with indirect coverage changes @@ Coverage Diff @@
## main #18820 +/- ##
==========================================
+ Coverage 68.53% 68.78% +0.25%
==========================================
Files 420 420
Lines 35619 35619
==========================================
+ Hits 24410 24501 +91
+ Misses 9777 9695 -82
+ Partials 1432 1423 -9 Continue to review full report in Codecov by Sentry.
|
dac8a24
to
2d99225
Compare
/assign @ahrtr |
/ok-to-test |
2d99225
to
dfa7b44
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
458fd16
to
3385c23
Compare
Please try to breakdown the PR. We love small PR to make the review easy, although this PR is just mechanical changes. |
3385c23
to
fa2bd5d
Compare
fa2bd5d
to
44eda63
Compare
/test pull-etcd-integration-1-cpu-amd64 |
94c8c18
to
6d896a0
Compare
/retest |
c71b13a
to
406698d
Compare
/retest |
/test pull-etcd-integration-1-cpu-amd64 |
8377832
to
b6764b4
Compare
I hold on this to apply gofumpt first |
b6764b4
to
efa2610
Compare
c4ff93b
to
6c560ab
Compare
/retest |
6c560ab
to
6a8afb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please breakdown this PR to smaller ones, thanks
6a8afb9
to
db069c0
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
db069c0
to
eb95361
Compare
Description
This uses testify instead of testing for t.Fatal calls
Related to #18972