Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a DLocker interface for distributed locker #18779

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 24, 2024

Also updated the contrib/lock example to demo how to use the DLocker.

For more background, please refer to the article by Martin Kleppmann.

  • It should be an improvement to help users better use etcd as a distributed lock.
  • It's also backward compatible. It won't break any existing applications

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.78%. Comparing base (18eb5c6) to head (bddc7a9).

Current head bddc7a9 differs from pull request most recent head 9786c9e

Please upload reports for the commit 9786c9e to get more accurate results.

Files with missing lines Patch % Lines
client/v3/concurrency/mutex.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
client/v3/concurrency/mutex.go 63.75% <0.00%> (+2.71%) ⬆️

... and 16 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18779      +/-   ##
==========================================
+ Coverage   68.74%   68.78%   +0.04%     
==========================================
  Files         420      420              
  Lines       35512    35515       +3     
==========================================
+ Hits        24411    24430      +19     
+ Misses       9671     9659      -12     
+ Partials     1430     1426       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18eb5c6...9786c9e. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Oct 24, 2024

/test pull-etcd-verify

I want to check if it was a flake in govet.

Also updated the contrib/lock example to demo how to use the DLocker

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr
Copy link
Member Author

ahrtr commented Oct 26, 2024

/test pull-etcd-integration-1-cpu-amd64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants