-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sstable: explore index size optimizations #97
Comments
@ajkr do you have an inside knowledge on this? |
I remember |
Something I've been meaning to ask you about: we saw a situation once where keys larger than a data block were written to a table. The result was that every data block had 1 entry, and the index block was essentially the same size as all of the data blocks combined. I think we could avoid this situation if there was a bit more complexity in the sstable block boundary heuristics. Specifically, we shouldn't allow a block to contain only a single entry if the key for the entry is larger than the target block size. On the other hand, perhaps it isn't worth futzing with the sstable block boundary heuristics, and instead put effort into blob (wisc-key) storage of large entries. |
We have marked this issue as stale because it has been inactive for |
We have marked this issue as stale because it has been inactive for |
Add writer, reader and iterator types for index blocks. This commit considers and resolves most of cockroachdb#97 and cockroachdb#2592. Close cockroachdb#97. Close cockroachdb#2592.
Add writer, reader and iterator types for index blocks. This commit considers and resolves most of cockroachdb#97 and cockroachdb#2592. Close cockroachdb#97. Close cockroachdb#2592.
Add writer, reader and iterator types for index blocks. This commit considers and resolves most of cockroachdb#97 and cockroachdb#2592. Close cockroachdb#97. Close cockroachdb#2592.
RocksDB has added version 3 and version 4 sstable formats:
<offset, size>
to a delta encoding that usually only stores<size>
.There is no particular urgency to supporting these formats, but we should investigate whether these format changes move the needle on any benchmarks.
Jira issue: PEBBLE-185
The text was updated successfully, but these errors were encountered: