CURATOR-719: Fix orSetData for parallel create calls #510
+109
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoustonPutman
force-pushed
the
parallel-creates
branch
from
73e1cb8
to
85fd82d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CURATOR-719
This fix really just lets the
catch (KeeperException.NodeExistsException e)clause catch exceptions thrown in theif (createParentsIfNeeded)clause. Previously, since the twocatchstatements were for the same try, theKeeperException.NodeExistsExceptionlogic would not be called if that error was thrown when creating the node after creating the parents. This case can easily be seen when trying to call create.orSetData() in parallel on the same node, while creating parents if needed. This is because theNoNodeExceptionwould be thrown for both parallel calls, but only one would be able to create the new node in the catch statement, and the other would get an un-catchableNodeExistsException.