Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow migration of maxCodeSizeConfig to transitions.contractsizelimit #1623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vdamle
Copy link
Contributor

@vdamle vdamle commented Mar 10, 2023

  • Require genesis to specify max contract size using Transitions config.
  • Add checks to allow migrating from a prior maxCodeSizeConfig to contractsizelimit specified in Transitions config.
  • NOTE: Remove support for legacy max code size genesis configuration by rejecting genesis config that specifies only maxCodeSizeConfig or maxCodeSize and maxCodeSizeChangeBlock.
  • cosmetic enhancement to a log message on startup to include Transitions since this is useful information for node operators.

FYI, given that the notice to use Transitions in lieu of the legacy max code size config parameters has been advertised for more than a year, I felt that it is not premature to remove support for it.

Fixes: #1622

* Require genesis to specify max contract size using Transitions config.
* Add checks to allow migrating from a prior maxCodeSizeConfig to
  contractsizelimit specified in Transitions config.
* Remove support for legacy max code size genesis configuration by
  rejecting genesis config that specifies only maxCodeSizeConfig or
  maxCodeSize and maxCodeSizeChangeBlock.
* cosmetic enhancement to a log message on startup to include
  Transitions since this is useful information for node operators.
Copy link
Contributor

@antonydenyer antonydenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed it's been a fair amount of time. However, the docs need a tidy up first 😏

@vdamle
Copy link
Contributor Author

vdamle commented Mar 17, 2023

@antonydenyer Based on the requested change comment, I assume you'd like me to take a stab at updating the docs? If so, could you please point me to the github repo for it? https://docs.goquorum.consensys.net/ has a link to https://github.com/ConsenSys/goquorum at the top, which either does not exist or is a private repo. Let me know.

@antonydenyer
Copy link
Contributor

These two are my main concerns. The problem is that the examples are in a lot of places!

https://github.com/ConsenSys/doc.goquorum
https://github.com/ConsenSys/quorum-dev-quickstart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error migrating from legacy maxCodeSizeConfig to Transitions.contractsizelimit
2 participants