Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcd raft package to v3.3.27 #1595

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

denis-gudim
Copy link
Contributor

@denis-gudim denis-gudim commented Dec 25, 2022

This PR provides the following changes for Raft consensus protocol service:

  1. Removed dependencies to not up-gradable etcd module https://github.com/ConsenSys/etcd v3.3.13 and replaced to vanila https://github.com/etcd-io/etcd v3.3.27 version.
  2. Moved changes by Quorum team from obsolete https://github.com/ConsenSys/etcd package to main repository (added required code only).
  3. Added types compatibility between customized by quorum team and source raft packages
  4. Added few minor changes to Raft consensus service source code

The main idea of this PR is to remove obsolete etcd package and provide ability to upgrade etcd package easier further.

@denis-gudim denis-gudim marked this pull request as ready for review December 26, 2022 16:06
@baptiste-b-pegasys
Copy link
Contributor

cool great job

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2023

CLA assistant check
All committers have signed the CLA.

@denis-gudim denis-gudim force-pushed the feature/update_etcd_raft_package branch from 4cd0144 to 15a87ab Compare January 2, 2023 09:09
@denis-gudim
Copy link
Contributor Author

cool great job

thanks a lot
added small addition changes: restored etcd package structure in raft/etcd directory

@baptiste-b-pegasys
Copy link
Contributor

Sorry for late answer.
I tested upgrade of node, and I managed to do it by updating all the nodes (stop/new image/start nodes) at once only.
I think for raft it is OK because it is dedicated for dev or test setups.

@denis-gudim
Copy link
Contributor Author

Sorry for late answer. I tested upgrade of node, and I managed to do it by updating all the nodes (stop/new image/start nodes) at once only. I think for raft it is OK because it is dedicated for dev or test setups.

No problem. Thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants