Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPV6 Support #4

Closed
dvn0 opened this issue Sep 16, 2022 · 8 comments
Closed

IPV6 Support #4

dvn0 opened this issue Sep 16, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@dvn0
Copy link

dvn0 commented Sep 16, 2022

Doesn't seem to work with ipv6. That would be nice to have, and Go networking has pretty good support for it, in my experience. You have a lot of dependencies though, so hopefully there are no blockers.

Thanks for the useful project.

@gabrieldavid98
Copy link

Seems like ipv6 is not supported on lib used for multi-group Raft

@maxpert
Copy link
Owner

maxpert commented Sep 17, 2022

I can trace through code in dragonboat to see if passing IPv6 string will work or not.

@maxpert maxpert added the enhancement New feature or request label Sep 17, 2022
@maxpert
Copy link
Owner

maxpert commented Sep 17, 2022

Yep just verified seems like dragonboat won't allow IPv6, might have to open ticket here
image

@maxpert
Copy link
Owner

maxpert commented Sep 17, 2022

Closing issue since it's not something fixable within scope of this project. I've opened ticket on dragonboat side though:
lni/dragonboat#255

@maxpert maxpert closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2022
Repository owner deleted a comment from ehmry Sep 18, 2022
@dvn0
Copy link
Author

dvn0 commented Sep 18, 2022

@maxpert where is the screenshot from? i.e. which dragonboat project and file? thanks for taking a look.

@maxpert
Copy link
Owner

maxpert commented Sep 18, 2022

@dvn0 yes this is from dragonboat project itself. We will need to make a contribution to dragonboat for Marmot to use it.

@dvn0
Copy link
Author

dvn0 commented Sep 18, 2022

Thanks @maxpert, but it would be more helpful to know exactly what module contained this, so I don't have to clone everything and walk through the methods. Anyway, that's what I did and tracked it down to here: https://github.com/lni/goutils/blob/master/stringutil/regex.go#L31

@maxpert
Copy link
Owner

maxpert commented Sep 18, 2022

@dvn0 you are spot on. This is precisely the place I took snapshot from in my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants